Hacker News new | ask | show | jobs
by mattbrewsbytes 1832 days ago
Go talk to your manager and say most of what you said above, except the "I quit" part. Your manager is there to help you succeed. They want you to succeed since they picked you over others. Ask for them to provide feedback on a PR and what it needs to get over the finish line. PR's having problems is a good sign that people care and are doing code reviews instead of rubber stamping everything.
2 comments

I agree with all of this advice, and would just add that if you find yourself turning in PRs that then need some changes before they can be merged, a strategy that worked for me early in my career was reviewing my own code as if I was reviewing another person's pull request. If you have turned in a few PRs that needed work then you already have a few examples of the kind of thing that your colleagues are looking for, and you can look at your own code with those things in mind. If you can, I would try to put a little time between writing the code and reviewing it so your mind can reset a bit. For me that meant wrapping up the code in the evening and then reviewing it first thing in the morning.
Yea this.

PR with problems just needs course corrections on the approach, nothing personal.