Hacker News new | ask | show | jobs
by lukey_q 1834 days ago
I agree with all of this advice, and would just add that if you find yourself turning in PRs that then need some changes before they can be merged, a strategy that worked for me early in my career was reviewing my own code as if I was reviewing another person's pull request. If you have turned in a few PRs that needed work then you already have a few examples of the kind of thing that your colleagues are looking for, and you can look at your own code with those things in mind. If you can, I would try to put a little time between writing the code and reviewing it so your mind can reset a bit. For me that meant wrapping up the code in the evening and then reviewing it first thing in the morning.