Hacker News new | ask | show | jobs
by arberx 1897 days ago
Back up and running: https://forkmon.ethdevops.io/

Might take a bit to sync
1 comments
fjl 1897 days ago
It's not fixed yet, the OE instance in forkmon was syncing the whole time and hasn't hit the issue yet.
link
arberx 1897 days ago
You sure? Thought it was in a failed state earlier?

I think a block recently processed on OE, that's why it's showing as good.

But yeah, don't think it's fixed yet.

link
fjl 1897 days ago
The fix is in https://github.com/openethereum/openethereum/pull/364

Actually, it's this commit of the PR: https://github.com/openethereum/openethereum/pull/364/commit...

link
makomk 1897 days ago
Looks like some really subtle and (as far as I can tell) undocumented aspect of Ethereum internals tripped them up.
link
AgentME 1897 days ago
They didn't properly implement EIP-2929 (https://eips.ethereum.org/EIPS/eip-2929). I looked at the first section of the code diff in the PR and it matched up with stuff already documented in the EIP, so I wouldn't assume the issue was because of undocumented stuff. Multiple other Ethereum implementations managed to implement the EIP-2929 spec correctly.
link
runeks 1897 days ago
386 files changed? This has to include more than just the fix, right?
link
warp 1897 days ago
Looks like they've extracted it to a separate hotfix PR here:

https://github.com/openethereum/openethereum/pull/366

link
xiphias2 1897 days ago
Shouldn't at least a unit test be added before accepting a pull request?

We're talking about 15% of a 300 billion dollar currency.

I have written tests for smaller things than that.

link