|
|
|
|
|
|
by tetron
2504 days ago
|
|
|
One thing that can be really hard is when someone turns in a lousy piece of code and you end up basically telling them how to rewrite it line by line in the review because they don't know how to do it right. These kinds of reviews need to stay positive because they can be super frustrating for both participants. |
|
|
When reviewing code I prefer to ask questions. - Would a switch statement be better here than a nested if/else? - Would this code be better if it was split into smaller logical chunks? - Should this code be over in this library rather than here?
You give them the opportunity to think about it, justify their decision if it's 50/50, and own the changes.
These are generally questions about re-usability.