Hacker News new | ask | show | jobs
by dwd 2504 days ago
Yeah, you don't want to end up there.

When reviewing code I prefer to ask questions. - Would a switch statement be better here than a nested if/else? - Would this code be better if it was split into smaller logical chunks? - Should this code be over in this library rather than here?

You give them the opportunity to think about it, justify their decision if it's 50/50, and own the changes.

These are generally questions about re-usability.