Hacker News new | ask | show | jobs
by jerf 2607 days ago
It is. It's a backwards-compatibility magic string hack. I would suggest new code uses the new, formal ways of obtaining the same result.

(I'm not defending it so much as explaining it. I'm not sure how I feel about it myself.)
2 comments
masklinn 2607 days ago
Backwards compatibility with what? You have to change the code to do anything new, that change could be using a different function entirely.
link
jerf 2607 days ago
See my apology below. I was wrong.
link
smudgymcscmudge 2607 days ago
> I would suggest new code uses the new, formal ways of obtaining the same result

I missed that. How else do you wrap an error with xerrors?

link
llimllib 2607 days ago 

    return errors.Wrap(err, "read failed")
link
acrispino 2607 days ago
That is not part of xerrors at this point. Rationale: https://github.com/golang/go/issues/29934#issuecomment-46420...

Personally, I don't care for "string magic"

Edit: Instead of making another post, I'll add this here. It also feels odd that concerns about xerrors.As possibly panicking at runtime are considered addressed by the addition of a go vet check: https://github.com/golang/go/issues/29934#issuecomment-46252...

I am not opposed to go vet, to be clear, but one of the aspects of the go compiler is that it does not warn, only errors out if compilation can't proceed. But the design of xerrors.As is fine because go vet acts like a compiler warning might? This is an aesthetic complaint more than anything else, but it still doesn't sit right with me.

link
llimllib 2606 days ago
Thank you, my bad!
link
smudgymcscmudge 2607 days ago
That's what I do now with pkg/errors, but I don't see a xerrors.Wrap in the docs or any mention of it in the proposal.
link
jerf 2607 days ago
My apologies, I seem to have confused the two packages. I don't see it in the godoc either. In which case I echo your desire to have an explicit method of formatting and wrapping.

I suppose it won't take long for a component of one of the gometalinter or golang-ci or whatever to develop a "Errorf used without %w in the final position" warning, which will be good enough for me, but it would be better to have something like Wrap officially, IMHO.

link