Hacker News new | ask | show | jobs
by kazinator 4031 days ago
Do not expand arguments with unquoted

  $*
Use:

  "$@"
You probably want

  local HASH=...
and

  local DIRTY=
in there.

Also, why mix the old style

   `command ...`
and

   $(command ...)
expansion.
1 comments
johnkeeping 4031 days ago
`local` is a bash-ism so it's best avoided in this context, and the command is running in its own shell anyway so the variables can't pollute anything else.

The other comments are 100% correct.

link
kazinator 4030 days ago
> so the variables can't pollute anything else

The variables can already exist in the environment. One of them is tested by a statement that is reachable without that variable being initialized in that script.

A fix that keeps the script POSIX would be to initialize the variable.

link