Hacker News new | ask | show | jobs
by xavierd 4059 days ago
I would say you're documenting way too much: the obvious shouldn't need documentation.
1 comments

It's more a matter of what you consider to be obvious in this case. In my experience, especially regex matching can become very not-so-obvious if you're coming back to code you wrote some time ago. Or if someone else is reading it.

		# Do NAT table lookup
		n = natlookup( p1, p2 )
is clearly unnecessary. If natlookup doesn't do a NAT table lookup, it's a badly named function.