Hacker News new | ask | show | jobs
by hamburglar 4084 days ago
I think I must be missing something, because this looks to me like a less-elegant reinvention of the functionality of a handful of already extant promise libraries. A library like 'when' already does all of this, and is much more composable. As an obvious example, there is no reason to clutter up your interfaces with specialized things like timeout parameters when a timeout something you can transparently wrap on any promise without changing its interface one bit.
1 comments

Yeah I feel the same way. So many others do this; hell I'm even building a few of these into my current library. Seems like better language constructs for handling asynchronous stuff will be nice (like ES6 promises though obviously it doesn't do everything this library does but it does enough to make it easier to do when needed).

Edit: Also where are the unit tests?

From a quick glance over Crockford's other repositories on GitHub, it doesn't seem like any of them have unit tests. Is this something he's known for not believing in?
I thought he may have used JSDev[1] to do some unit testing (which I understand why he set it up but it feels so awkward to me) but I don't see anything. No idea; he's certainly talked about the privacy of closing methods and unit testing but I thought he still did it just with JSDev.

[1] https://github.com/douglascrockford/JSDev

+1 for tests.