Hacker News new | ask | show | jobs
by pnathan 4099 days ago
Worth noting: some shops will summarily reject on code review any refactor that isn't part of the ticket/issue.
1 comments

Along the same lines: it's considered good practice to perform a refactoring in a separate commit from code which changes behavior. This makes it much easier to review the code, as you can look at the changes in isolation. If you refactor and then change behavior in a single commit, it can result in a very confusing change.
Some shops reject commits that are refactoring. "Deliver value, don't just goof off". :-)
Sounds like they'd be awful places to work.