Hacker News new | ask | show | jobs
by gknoy 4126 days ago

  The person commenting on his pull request was not being a snob. 
  He was making sure there was architectural coherence across the board. 
This is actually the essence of the article. When people criticize things in our code that we see as "trivial", it's EASY to mistakenly ascribe that to snobbery or being a jerk. The entire point of this article is that we should look for the value that our peer is trying to add by pointing out inconsistencies or better ways of doing things.

Some of the best pull request comments for me have been the ones that made me say, "Dammit! .... you're right." Many of those PR comments have been replaced by impersonal linting tests that do the same, but the net result is still that I feel proud of what I write.