Hacker News new | ask | show | jobs
by jgraham 4235 days ago
At least for code review, the problem isn't pull requests as-such. The features that drive me to use other tools (on top of guthub hosting, often) are things like:

* The ability to mark which commits/files have been reviewed and so track progress.

* The ability to distinguish resolved and unresolved issues

* The ability to assign a reviewer based on which code is being altered in the PR.

* Useful handling of history rewriting during review.

I also think that the PR model could be implemented in a way that would make for better collaboration. At the moment, if someone submits a PR that has some issues and you want to help them fix those issues it's a huge pain because the commits typically live in their fork to which others usually don't have push access. It would be a considerable improvement if PR branches were set up in such a way that both the original submitter and the people with commit access to upstream could push to the review branch.

1 comments

Beanstalk - private repo hosting for business - just released a brand new code review tool that we've been beta testing for a while now. It's rather nice and addresses many of the rough edges of pull requests. It's definitely for same-company teams as opposed to large open-source collaborative projects, though.

http://beanstalkapp.com

We host all of our private repos with Beanstalk, and use GH for our open source repos.