|
|
|
|
|
by heatish
4329 days ago
|
|
Does seem a bit broken, some simple validation on names and rate limiting/checking for duplicates on messages will help from people spamming and trying to get script tags to run. A set height and Overflow:scroll on the livechat div as well as the user list div seems pretty mandatory as well. "Private" rooms seem to be getting the broadcasts from everyone or everyone is being placed into the same 'private' room, can't tell which. I can open up as many 'user' views as I want with the same session id (on connection if session id exists load them into the chat else prompt them for the username). edit: I see the validation now, checking if sessionStorage.username is undefined doesn't seem to be working though. Refreshing the page breaks as well, never triggers the loadhistory event that way. It's cool, socket.io is pretty awesome, needs a little more work though |
|