|
|
|
|
|
by ge0rg
4342 days ago
|
|
From a short look, I tend to agree with you. > memcpy(packet + 1, &con->ping_request_id, sizeof(uint64_t)); Copying multi-byte values into a network packet is a typical error made by novice developers - this will bite you hard as soon as somebody compiles the code on a Big Endian machine. Even if you might get away with this on opaque elements like a ping ID, the general approach should not be followed. |
|
In all cases where it does matter, the values are converted.
Tox has been confirmed working on big endian machines by many people.