|
|
|
|
|
by afternooner
4407 days ago
|
|
It could be a bad sign, or it could speak to priorities, and your priorities are not their priorities it seems. Personally, I accept all pull requests that are solid, written to my standards, fix or extend a feature that is a priority, are accompanied with unit tests, and do not impact or impinge on another feature or future feature. I do not however accept all pull requests. Part of this is that if there is no demand and it's a single individuals edge case, then I'll very heavily scrutinize the patch. If I don't agree, don't understand exactly what every line is doing, or do not feel it will be used by a significant portion of the user base then I won't pull it. Because moving forward, I will have to maintain it, and that isn't free. And if people don't like that, they can fork it. |
|
It's one thing that my pull hasn't been accepted, the other bigger concern is the nature of the unpatched code that says to me that no one serious has used Ruby Motion. We aren't talking a hobbyist open-source project here, this is a partially open-source commercial offering.
Source: I am a Ruby developer who has to develop native on occasion... and I run a company who's job it is to deploy beta/in-house applications to mobile devices. I just ran a quick sql query and 43.7% of the hundreds of thousands of applications we host are deployed with enterprise provisioning. I wouldn't call this a personal edge case.