Hacker News new | ask | show | jobs
by sdougbrown 4423 days ago
I think you'll probably want to remove those font-size adjustments and re-assess afterwards. You'll find that the majority of the redesign is indeed sized with ems, including all text sizes. You'll also want to adjust #header_wrapper to position:absolute if you deice that you're not going to use the settings to disable the fixed header behaviour - setting static without adjusting the settings will be unpleasant. To be safe, in case you want to play with the header settings later, you probably want to actually make that selector `.set-header--fixed .header-wrap { position: absolute' }`
1 comments

I'll re-review. The font sizes I suspect I'll keep. They're pretty standard across most sites I use, though for text-heavy ones that are actually document-based, I'll even bump them up further -- 17-18pt for true long-form reads.

Static for header hasn't been an issue for me. Headers that are sufficiently annoying just get iced ;-)