Hacker News new | ask | show | jobs
by entropy_ 4421 days ago
You don't need to force push at all. You could just apply the changes to your PR in a different branch(completely local, rewrite history as much as you want, etc, etc) and then submit a second PR with that.
1 comments
davexunit 4421 days ago
A whole new PR? That just shows how broken PRs are if that's the solution to this problem.
link
jimktrains2 4420 days ago
It's _A_ solution, but not a good one. I think most people consider it OK to force-push a PR branch and update the existing pull request.
link
davexunit 4420 days ago
There's a lot of opportunity for destruction with a force push, so it seems weird to consider it acceptable in a code review workflow.
link