Hacker News new | ask | show | jobs
by neoveller 4515 days ago
The step of just adding yourself to the userlist seems ill-conceived. Automatic merges are just going to overwrite the last person added unless manually merged. Can I propose this just use github for authentication, and only allow those on the contributors list (http://developer.github.com/v3/repos/#list-contributors) to successfully log in?
1 comments

Make a pull request! Also change the readme, faq etc.

I like this better also because you can update the list without restarting the server.

Still waiting on my first pull request to get merged (msied).
Op here: sorry, we got a little back logged processing the PRs when we hit the front page, and also because of exactly this username merge problem (whoops).
Added the proposed auth method. Still awaiting merge for previous pull request: https://github.com/larvalabs/pullup/pull/11
Awesome, thanks. We're going to go through most of this in detail in the morning, getting late here for us but this looks awesome.