Hacker News new | ask | show | jobs
by Aldo_MX 4575 days ago
You can always submit a patch, remember that the source is Open, and everyone is welcome to contribute.

My cringe with Firefox are misfeatures like window.onbeforeunload. They deliberately break the expected behavior due to an unreasonable decision, but no browser is perfect.
4 comments
Skalman 4575 days ago
That patch would not be welcome. The patch to make the behavior intuitive is literally to remove "!important" from one CSS file. They're not changing because they're afraid to break the web.
link
mburns 4574 days ago
> They're afraid to break the web.

They tried a fix and it broke YouTube. So it seems like a reasonable fear. https://bugzilla.mozilla.org/show_bug.cgi?id=349259#c54

> The patch ... is literally to remove "!important" from one CSS file

It isn't a simple one line fix, as Firefox developer kindly explained. https://bugzilla.mozilla.org/show_bug.cgi?id=349259#c76

>That patch would not be welcome.

They describe what work would be required (and where the changes would likely be) for the patch to be accepted in the bug. https://bugzilla.mozilla.org/show_bug.cgi?id=349259#c80

link
Skalman 4574 days ago
It's a one-line fix to make it intuitive, but that's not what's needed here. Ultimately there should be some spec so that browser vendors can converge towards a single behavior.
link
natural219 4575 days ago
Can you elucidate? From my naive understanding of the back button API, I always thought Firefox's default behavior (not firing onpopstate on page load) made way more sense than say Chrome's. I guess both vendors make silly decisions sometimes.
link
ancarda 4575 days ago
>remember that the source is Open, and everyone is welcome to contribute.

Problem is, not everybody knows C++. Having a bug open for 7 years makes me think the issue will never be resolved. All I can do is wait or use another browser. One annoyance I have with Firefox is the lack of built in keychain support. This really summarizes how I feel: https://bugzilla.mozilla.org/show_bug.cgi?id=106400#c94

link
untog 4575 days ago
That fix wouldn't require C++ knowledge at all. It involves changing some CSS. The issue is the effect it would have on sites that expect it to be styled the way that it is.
link
ancarda 4575 days ago
The one I linked to ( https://bugzilla.mozilla.org/show_bug.cgi?id=106400 ) would, it was a different example.

As for the original bug, this post: https://bugzilla.mozilla.org/show_bug.cgi?id=349259#c82 seems to suggest every browser but Firefox supports changing line-height. Wouldn't Firefox be going against the expected behavior?

link
lovskogen 4574 days ago
I don't know enough code to do that.
link