|
|
|
|
|
by CyruzDraxs
4578 days ago
|
|
The contributor also had not signed a CLA, and the commit message did not follow the guidelines. Ben should have been more explicit in his initial post about his reason for denying the commit. Isaac shouldn't have merged the pull, which violated the guidelines. The community shouldn't have raised their pitchforks without first seeking an explanation. Everyone involved could use a dose of professionalism. |
|
An invalid but well-meaning pull request? Better give it a cryptic rejection. A rejected by politically sensitive pull request? Better pull rank and force its acceptance in violation of project guidelines. Main project backers violating project guidelines? Better reverse their commits with a passive aggressive commit message. Project lead reversing commits? Better post a vitriolic blog post about how he is a terrible asshole who should be fired!
Would it have been that hard to bounce a couple of emails back and forth, and sort it all out in private? Christ.
(Add good point about the CLA. Although needing a CLA to change a pronoun in the docs seems silly, I think it highlights that a pull request was the wrong tool for this.)