|
|
|
|
|
by onion2k
4593 days ago
|
|
It's a fun and cute resume, but delving in to the code you see things like; function blinkRobbyEyes()
{
if (layersMovement != "not moving 2")
{
$(robbyEyesCloseDiv).fadeTo(0,1);
$(robbyEyesCloseDiv).stop().delay(300).animate({opacity: 0}, 0, function() {});
}
}
"if (layersMovement != "not moving 2")" is a boolean that should be passed as a parameter if you're ever going to write a working unit test against that function. Consequently, it shows a pretty poor knowledge of "making nice looking and maintainable HTML5 scrolly animations" in any sort of a real-life environment. Many people can make fancy webpages; someone with "the best resume ever" would be able to make fancy webpages with code that's relatively well abstracted in to testable, reusable functions. |
|