Hacker News new | ask | show | jobs
by onion2k 4593 days ago
It's a fun and cute resume, but delving in to the code you see things like;

  function blinkRobbyEyes()
  {
	if (layersMovement != "not moving 2")
	{
		$(robbyEyesCloseDiv).fadeTo(0,1);
		$(robbyEyesCloseDiv).stop().delay(300).animate({opacity: 0}, 0, function() {});
	}
  }
"if (layersMovement != "not moving 2")" is a boolean that should be passed as a parameter if you're ever going to write a working unit test against that function. Consequently, it shows a pretty poor knowledge of "making nice looking and maintainable HTML5 scrolly animations" in any sort of a real-life environment. Many people can make fancy webpages; someone with "the best resume ever" would be able to make fancy webpages with code that's relatively well abstracted in to testable, reusable functions.
6 comments

He does only give himself three lobsters for jQuery
Maybe someone with "best resume ever" has a better understanding what and when if worth testing and not yet embraced cargo-cult testing? I'd be more worried about the massive pollution of the global namespace. That said I am not a fan of such resumes. They do show skill, but they usually don't show the ability to choose the right tool for the job.
I've always found this interesting. If you're a developer, it should be your number one priority to make sure the code you write for your own site be top notch. God knows how much we all complain about other people's code, you should know however cool it is, developers are going to crack the hood and see how good the code is.

Great idea and quite original. I still give him rube cred for having such a nice concept despite the flaws in his code.

You know, you just gave me an idea: not to have top quality code on personal web site, but have a comment instead "I can explain what's wrong with this code or any other you will show me and how to fix it". I think that gives opportunity for much more interesting discussion :)
Agreed that the code is not very good, the idea of the animated resume was great, despite some technical issues it may have.

My first impression would be that he is a very creative professional with good designing skills. Regarding the programming I totally agree that it have a lot of flaws and lack of basic testing capabilities.

Yeah, that's what I thought.

The animation are fun, but having reviewed main.js and style.css, he can't reasonably pretend he's a "master" in css/javascript.

Please write/amend some ECMA/CSS specs or hack rendering engines first to pretend to be so.

He's a graphic designer first and foremost, not a programmer. His website seems like the product of a very ambitious person.