Y
Hacker News
new
|
ask
|
show
|
jobs
by
marc_omorain
4605 days ago
It seems odd to see a commit in this day and age with no unit test. When you make a new newkey struct the clean-up callback should be NULL.
2 comments
noselasd
4605 days ago
That's the fun with C, it would be quite unlikely the malloc call in a unit test for this didn't happen to zero initialize the struct.
link
meowface
4605 days ago
Yep. You may get different results based on the code path taken, the compiler, and (maybe?) the OS. Most of the time the value at that memory location will probably be a zero byte (or a zero word/dword), but sometimes it may not.
link
djmdjm
4605 days ago
We committed a regression test fix separately.
link