Hacker News new | ask | show | jobs
by dmethvin 4774 days ago
I can't speak for the other projects, but the data is completely wrong and misleading for jQuery. It looks like this code only counts a pull request as merged if it's landed with a merge commit. It's much more common for us to touch up the pull request (for example, fixing small style or commit message issues), then rebase, possibly squash some commits, and land via a fast-forward commit.

So this is "accepted": https://github.com/scalatra/scalatra/pull/267

But this is not: https://github.com/jquery/jquery/pull/1255

1 comments

The hosting sites need to start providing a way for a maintainer to update or supersede a PR, as well as a way to track prior versions of commits in a PR after the PR has been updated post-review.