Hacker News new | ask | show | jobs
by aaronz8 4793 days ago
Hey, great idea! I found a couple bugs:

1. There is not much user input validation, if any. For example, I submitted <h1>Broken</h1> to the San Francisco page, and it broke the "Explore Review Frequencies" section.

2. There is no checking for repeating submissions. Using a while loop on "send_review('stuff')" repeated my submission until I refreshed the page. A way to fix this would be to save an array of user ids per topic, but unfortunately that would require user login. Or, you could save an array of ip addresses, though obviously there are easy ways to get around that.

1 comments

By the way... feel free to delete all the "broken" tags in the San Francisco page...
Hey thanks for letting me know of the bugs. Presently I am not disallowing repeated submissions. Earlier submitting a review required you to be logged in. However, I thought that might put off users who didnt want to go to the hassle of signing up with an account. But yes that is something I need to solve. Also, you are correct - there is not much user input validation. So lots of work that needs to be done.