No, merely analyzing or discussing the law generally does not constitute the practice of law. If it did, plenty of newspaper articles, law review journals (often written by law students), non-attorney legal aid, and legal pamphlets would be prohibited.
If you want something more concrete, I googled it, and in New York, there appears to have been a case New York County Lawyers’ Association v. Dacey, in which Dacey wrote a book "How to Avoid Probate!", and the NYCA accepted a dissent in a lower court, stating in part:
Does the writing, publication, advertising, sale and distribution of "How To Avoid Probate!" constitute the unauthorized practice of law within the meaning of subdivision B of section 750? It cannot be claimed that the publication of a legal text which purports to say what the law is amounts to legal practice. And the mere fact that the principles or rules stated in the text may be accepted by a particular reader as a solution to his problem does not affect this.
and later humorously quoting:
"[I]t is a prized American privilege to speak one's mind, although not always with perfect good taste, on all public institutions" (Bridges v. California, 314 U. S. 252, 270)
I am honestly so surprised that everyone on HN is so naive that they take political statements like this at face value.
Politicians routinely say they will do things they do not have the authority to do, and it's often very important to understanding what will actually happen to have some understanding of what authorities are available to them, or at the very least ask Google/LLMs about it.
Similarly, it's fine for people to have opinions on food, dental hygiene, and the tax code without being a chef, a dentist, and an accountant.