|
|
|
|
|
|
by skydhash
18 days ago
|
|
|
Not really, because that one commit represent a logical changes to the codebase. It’s either in or not. Splitting it would be only cosmetic. That’s what a good PR in my opinion. Presenting a series of patches is good in an email format because when I’m adding them, I can evaluate each and decide whether I want it or not. But GitHub (and forges that copies it) is lacking in that regards without me taking over the branch. So the word is to make the PR the unit of changes, and only review the whole diff, not the individual commit. |
|
|