[TimorousBestie]

> You are doing it wrong.

I didn’t write any of it. I occasionally get assigned PRs written (or not, in this case) by other devs.

> Claude can generate tests and verify the code better than humans now.

It certainly didn’t do that in this case.

> I don't trust humans to get things right anymore -- I have a PhD and Claude knows all the math and libraries better than me.

If it knows all the libraries so well, why did it add a bespoke implementation?

[jmalicki]

If you're getting code without tests to review in a PR, that should be an instant reject without even looking at the code.

[TimorousBestie]

> If you're getting code without tests to review in a PR, that should be an instant reject without even looking at the code.

Management didn’t like that the last time I was assigned a AI-gen PR and I like my job otherwise.

[waynecochran]

Go ahead and have claude add and run units tests for you as part of the PR review process.

[shusaku]

Claude is absolutely terrible at writing unit tests, this advice continues to perplex me. Coding agents usually slam you with hundreds of lines that do little more than “test” what is obvious. Maybe it’s good for an API revision or such. But for linear algebra where errors might not manifest unless suitably chosen inputs are generated based on expert knowledge, that’ll be useless.

[waynecochran]

Have you used Claude lately? It definitely will outperform a human at this task now.

[shusaku]

I use it literally every day. But please do not use it to generate tests on its own, it’s all sleight of hand. It does not (without substantial guidance and tweaking from an expert) have the capability to generate meaningful tests.

[jmalicki]

That's on the submitter of the PR to do. Don't put that burden on the reviewer.

[waynecochran]

No problem for claude. In fact I would have claude do the PR and go have lunch.

[danhorner]

Claude can’t have lunch yet.

[TimorousBestie]

I don’t get paid to do my job and then also the submitter’s job.