Hacker News new | ask | show | jobs
by bluefirebrand 27 days ago
> No, reviewing PRs in general is a delightful process

I don't know if this is a very universal feeling. I personally find reviewing code is tedious compared to writing it

Not just the process of reading the code and understanding it, but the back and forth can be miserable if the submitter isn't meeting you part way

I dunno. Maybe I'm the odd one out for thinking reviewing PRs is more of a chore than a joy

1 comments

That, not being sure if the submitter is willing to meet you part way, is exactly the miserable part I am talking about. Basically, you go in risking it's just a waste of your time. After some trust is established, or when the PR is from someone you already have some trust relationship, the dynamics are very different.

Yes, it can still be a slog to review someone else's code, but you usually have the feeling of "hey, this is probably something good".