|
|
|
|
|
by edg5000
5 hours ago
|
|
By stating you used an LLM it sounds as if you haven't vetted it. By mentioning the LLM in this hyped-up time, you're distracting from the actual deep work you've (presumable) done. By ensuring the patch is truly tight, and that the correspondence it tight (not LLM slop), there is no reason to suspect slop or reject it. Assuming it's a concentrated, well motivated patch. That being said, this patch set is very large with very wordy comments. I'm not sure if he submitted all of them at once. Personally I would not accept such wordy comments in my code. A typical LLMism. These comments should be smaller and part of the email. I also suspect the code change could be smaller. Today's LLMs do have a way of slowly poisoning a codebase by not being a tight as they could be. It tends to bloat the code up. Okay for some code, especially when bounded (e.g. module X is written by LLM, API authored by human). But in massive, established codebases, you can't accept even slightly bloated code since it will drag everything down. Also, GLM is a lot weaker than GPT and Claude I think. |
|