Hacker News new | ask | show | jobs
by annoyingcyclist 12 days ago
To me, if "you are responsible for what you write" is to mean anything in an org, it needs to come with teeth. If you are demonstrably _not_ responsible for what you write, that needs to be recognized and treated as underperformance. I've seen a couple orgs who had some flavor of "you are responsible for what you write" guidance, and they mostly fail to follow through on it. People who ignore that guidance and ship a lot of low quality stuff (code, design docs, PRs) survive perf cycles and tend to get shout outs from management for moving quickly. People who take it to heart will tend to look slower by comparison (their work may be better, but often not in ways that are legible or compelling to management), and may be less favorably viewed when it comes to raises, promos, and so on.

I have no reason to doubt the sincerity of the authors of that post (and enjoyed reading it), I just hope they have a good sense of how they're recognizing responsible and irresponsible use and taking that into account in a perf process.

1 comments

Author here. 100% agree with your sentiment. When we do performance reviews of engineers we take the time to comb over at least some of the PRs the engineer has written. We flag any patterns around code quality (regardless of whether it came from AI or not). This is on top of any other ongoing feedback we're giving.

E.g. in a recent review I wrote I picked up on an engineer not splitting up React components aggressively enough and over-relying on deeply nested ternaries. In that same review I also commended the engineer for being particularly excellent at explaining complex bugs to our support people and called out one example of a nasty race condition.

> When we do performance reviews of engineers we take the time to comb over at least some of the PRs the engineer has written.

Wait, whoever is reviewing the engineer isn't already familiar through exposure to – if not participation in – flow of work?

In general, yes. I believe there's a difference between writing a performance review based on your memory/notes of how someone was doing 6 months ago vs getting into the weeds of a sample of PRs/specs and reviewing those from a performance viewpoint.
For sure. It's why review should be as continuous as anything one wants to improve. Annual review is a relic from the gold watch era.