Hacker News new | ask | show | jobs
by simonw 24 days ago
The CEO of Shopify is filing PRs against their public repos: https://github.com/Shopify/liquid/pull/2056

(To be fair, he did build liquid and much of Shopify himself at the start of the company so he's not exactly inexperienced, but still.)
1 comments
khuey 24 days ago
I skimmed that PR briefly and it appears a) not to be slop and b) to be very reviewable as its structured as a series of small commits that each make one small change. This is far from the sort of management PR I'd fear.
link
suttontom 23 days ago
Am I going crazy? Is a PR with 94 commits that adds 1,600 LoC actually considered "very reviewable"? Please someone tell me if I'm crazy?
link