|
|
|
|
|
by kstenerud
30 days ago
|
|
> I did not much more than a cursory glance too, but found "./sandbox/create.go", a ~1300 lines long file with so much duplication even within just itself that I stopped counting. Really? What duplication did you actually find? I count a few small ones in buildMounts and ReadPrompt, maybe 20 lines or so, but hardly anything worthy of such an epithet. Admittedly, the parsing & escaping code and some utility functions could be moved outside to shrink the file, but otherwise I'm having trouble finding issues with the code. |
|
Look for slight variations of the same thing but with different paths, variables, or modes and I think you'd be able to spot the rest as well.