Hacker News new | ask | show | jobs
by Schnitz 53 days ago
But what problem does this actually introduce? If you are applying a patch you must already trust the source anyways and this isn’t harder to spot than a rogue file anywhere else in the patch as it looks the same.
1 comments

Field confusion. If you manually reviewed the diff in GitHub but did not pay attention to the commit message (which GitHub already collapses when long or may start doing any day they want), you are screwed.

Imagine the diff only has

  if (someIntParamThatShouldHaveBeenUInt < 0)
    throw new ArgumentOutOfRangeException();
Would you care who wrote it?