| This looks good, but, I noticed: > Supported Functions (v1)
> SUM, AVERAGE, COUNT, MIN, MAX, IF I would recommend switching to numerically stable algorithms for adding numbers and taking their averages sooner rather than later. Looking at the code[1], it looks like you are simply summing the numbers and dividing by count. If that is indeed the case, please switch to a stable average[2]. See also [3]. Additionally, I tried to test the executable[4] on Windows, but there is something wrong with input. Using Windows Terminal Version: 1.24.10921.0, characters are doubled on input. Regular Vim compiled using Visual C++ does not have this issue. When I press `:`, I get `::` in the COMMAND line. Then, every key I press gets doubled. This means I cannot `:q!`. :-) [1]: https://github.com/garritfra/cell/blob/99b0afc7a60a871b27452... [2]: https://www.nu42.com/2015/03/how-you-average-numbers.html [3]: https://en.wikipedia.org/wiki/Algorithms_for_calculating_var... [4]: https://github.com/garritfra/cell/releases/tag/v0.2.0 |
Use numerically stable algorithms for SUM and AVERAGE: https://github.com/garritfra/cell/issues/43
Keystrokes doubled in Windows Terminal: https://github.com/garritfra/cell/issues/44
Thanks!