|
|
|
|
|
by kakwa_
54 days ago
|
|
> I usually find it easier to take their branch, do all of that work myself (attributing authorship to commits whenever appropriate), push it to the master branch and close the PR than puppeteering someone halfway across the globe through GitHub comments into doing all of that for me. The PR system is great for reviewing changes within a dev team. But, indeed, when its an external contribution, it kind of falls apart. It's unrealistic to expect from an external contributor, often a one time one, to know the ins and outs of a project (code standards, naming tastes, documentation, tests, ...) I really like your workflow, and often did something similar in my projects (or merge in main, with subsequent fixes/realignments). But I'm wondering if it could be smoothed out and normalized by Github/Gitlab/Forgeo, or maybe at the version control software level. |
|