Maybe more an effective rhetorician than communicator. I suppose his communication does match the clarity of thought though... it's just that the thoughts are so jumbled he says 3 things that contradict each other in the same breath.
the point of rhetoric is persuasion or flattery, the point of communication (or argument as its usually framed going all the way back to Plato) is to accurately convey an idea or concept. In your average Trump speech the point is usually to evoke an emotion in his audience, not so much arguing anything in particular.
> I hate how he talks, but he seems to be an effective communicator if you only judge by results
Looking at Iran situation, absolutely not, results of Trumps communications are pure disaster. Looking at tariffs situation, absolutely not, results of Trumps communications are pure disaster. His communication is masterpiece of ineffective communication.
On the plus side, he is emotionally pleasing to certain kind of people and he is effective in bullying and humiliating close ones. If those are the goal, yes he is effective. But, he cant do much else.