Hacker News new | ask | show | jobs
by aw1621107 89 days ago
> The problem is the code unconditionally dereferences the pointer, which would be UB if it was a null pointer.

Only when NDEBUG is defined, right?
1 comments
saagarjha 89 days ago
No, the code that does this is always active
link
gottheUIblues 89 days ago
Right so strictly speaking C++ could do anything here when passed a null pointer, because even though assert terminates the program, the C++ compiler cannot see that, and there is then undefined behaviour in that case
link
aw1621107 89 days ago
> because even though assert terminates the program, the C++ compiler cannot see that

I think it should be able to. I'm pretty sure assert is defined to call abort when triggered and abort is tagged with [[noreturn]], so the compiler knows control flow isn't coming back.

link
aw1621107 89 days ago
Shouldn't control flow diverge if the assert is triggered when NDEBUG is not defined? Pretty sure assert is defined to call abort when triggered and that is tagged [[noreturn]].
link
saagarjha 89 days ago
Sorry, yes, I misread you
link