Hacker News new | ask | show | jobs
by i2talics 168 days ago
What good does it really do me if they "stand behind their work"? Does that save me any time drudging through the code? No, it just gives me a script for reprimanding. I don't want to reprimand. I want to review code that was given to me in good faith.

At work once I had to review some code that, in the same file, declared a "FooBar" struct and a "BarFoo" struct, both with identical field names/types, and complete with boilerplate to convert between them. This split served no purpose whatsoever, it was probably just the result of telling an agent to iterate until the code compiled then shipping it off without actually reading what it had done. Yelling at them that they should "stand behind their work" doesn't give me back the time I lost trying to figure out why on earth the code was written this way. It just makes me into an asshole.
3 comments
sb8244 168 days ago
It adds accountability, which is unfortunately something that ends up lacking in practice.

If you write bad code that creates a bug, I expect you to own it when possible. If you can't and the root cause is bad code, then we probably need to have a chat about that.

Of course the goal isn't to be a jerk. Lots of normal bugs make it through in reality. But if the root cause is true negligence, then there's a problem there.

AI makes negligence much easier to achieve.

link
nineteen999 168 days ago
If you asked Claude to review the code it would probably have pointed out the duplication pretty quickly. And I think this is the thing - if we are going to manage programmers who are using LLM's to write code, and have to do reviews for their code, reviewers aren't going to be able to do it for much longer without resorting to LLM assistance themselves to get the job done.

It's not going to be enough to say - "I don't use LLM's".

link
nradov 168 days ago
Yelling at incompetent or lazy co-workers isn't your responsibility, it's your manager's. Escalate the issue and let them be the asshole. And if they don't handle it, well it's time to look for a new job.
link
danaris 168 days ago
...what makes you think i2talics isn't the manager in this situation??
link
skeeter2020 168 days ago
>> Yelling at incompetent or lazy co-workers isn't your responsibility, it's your manager's

First: Somebody hired these people, so are they really "lazy and incompetent"?

Second: There is no one who's "job" is to yell at incompetent or lazy workers.

link