Hacker News new | ask | show | jobs
by necovek 179 days ago
Wow, that's a very arbitrary practice: do you remember roughly when was that?

I was in a team in 2006 where we did the regular, 2-approve-code-reviews-per-change-proposal (along with fully integrated CI/CD, some of it through signed email but not full diffs like Linux patchsets, but only "commands" what branch to merge where).
2 comments
SoftTalker 179 days ago
Around that time frame. We had CI and if you broke the build or tests failed it was your job to drop anything else you were doing and fix it. Nothing reached the review stage unless it could build and pass unit tests.
link
necovek 179 days ago
Right, we already had both: pre-review build & test runs, and pre-merge CI (this actually ran on a temp, merged branch).
link
marwamc 179 days ago
This was still practice at $BIG_FINANCE in the couple of years just before covid, although by that point such team reviews were reducing in importance and prominence.
link