[grannyg00se]

I upvoted your response because on one hand I do think you are correct in all of what you are saying.

But your previous post can be interpreted as an implication that the people themselves are neither smart, nor wise. A somewhat harsh attack. I re-read it with more emphasis on the "here" part of the sentence and it sounded a bit more as though you are saying that in this instance the people were not wise.

Pointing out incompetence is helpful, but it's also very useful to do so in a way that attempts to minimize the chance of an extremely negative interpretation.

[adgar2]

I expected an extremely negative interpretation. My criticism is harsh because the failure here was unacceptable.

Look at the pull request they merged in. Any line added to a script which starts with "rm -rf $VARIABLE" cannot be scrutinized enough.

The first commit was created at: 2012-09-30T10:25:44-07:00.

The pull request was accepted at: 2012-09-30T10:59:08-07:00.

34 minutes to accept on a Sunday morning. I suspect that wasn't 34 minutes of review. I suspect it was closer to 34 seconds of review.

Unacceptable.

[wtallis]

If virus scanners were common on unices, their primary purpose would be to watch for the string "rm -rf".

[tjholowaychuk]

shit happens, and then you die. when you have 50+ people that just "+1" an issue for long enough without helping, you tend to limbo-merge

[adgar2]

Engineers have responsibility.

Otherwise you're just throwing shit at a wall and seeing what sticks.

[aidenn0]

Sounds like 99% of software development to me, OSS or otherwise.