Hacker News new | ask | show | jobs
by biorach 200 days ago
The wider point is that copyright headers are a very important detail and that a) the AI got it wrong b) you did not notice c) you have not taken on board the fact that it is important despite being told several times and have dismissed the issue as unimportant

Which raises the question how many other important incorrect details are buried in the 13k lines of code that you are unaware of and unable to recognise the significance of? And how much mantainer time would you waste being dismissive of the issues?

People have taken the copyright header as indicative of wider problems in the code.
1 comments
menaerus 200 days ago
Yes, please then find those for now imaginative issues and drill through them? Sorry, but I haven't seen anyone in that MR calling out for technical deficiencies so this is just crying out loud in a public for no concrete reasons.

It's the same as if your colleague sitting next to you would not allow the MR to be merged for various political and not technical reasons - this is exactly what is happening here.

link
biorach 200 days ago
> Yes, please then find those for now imaginative issues and drill through them?

No, that is a massive amount of work which will only establish what we already know with a high degree of certainty due to the red flags already mentored - that this code is too flawed to begin with.

This is not political, this is looking out for warming signs in order to avoid wasting time. At this stage the burden of proof is on the submitter, not the reviewers

link
menaerus 200 days ago
Too flawed? Did you miss that tiny detail that MR fixes a long time issue for ocaml? This is exactly political because there's no legal or technical issue. Only fluff by scared developers. I have no stakes in this but I'm sincerely surprised by the amount of unreasonable and unsubstantiated claims and explanations given in this thread and MR
link
zeratax 194 days ago
I don't get why you do not understand why nobody wants to waste time on a MR where the author didn't even themselves have any interest on looking over it even once. https://github.com/ocaml/ocaml/pull/14369/files#diff-bc37d03... also all the unused functions...

did it fix a long time issue? maybe, but 9 tests for 13k lines doesnt give much confidence in that

and even if it worked perfectly, who will maintain this?

link