Hacker News new | ask | show | jobs
by kazinator 218 days ago
Why are you using the locale-specific [:space:] on source code? In your C source code, are you using spaces other than ASCII 0x20?

Would you have //d<0xA0>rest of comment?

Or some fancy Unicode space made using several UTF-8 bytes?
2 comments
wtallis 218 days ago
Tab characters can also be found in source code.
link
kazinator 218 days ago
Since you control the \\d format, why would you allow/support anything but a space as a separator? That's just to distinguish it from a comment like "\\delete empty nodes" that is not the \\d debug notation.

If tabs are supported,

  [ \t]
is still shorter than

  [[:space:]]
and if we include all the "isspace" characters from ASCII (vertical tab, form feed, embedded carriage return) except for the line feed that would never occur due to separating lines, we just break even on pure character count:

  [_\t\v\f\r]
TVFR all fall under the left hand, backspace under the right, and nothing requires Shift.

The resulting character class does exactly the same thing under any locale.

link
nerdponx 217 days ago
There's also [:blank:], which is just space and tab. Both I think are perfectly readable and reasonable options that communicate intent nicely.
link
kazinator 217 days ago
ISO C99 says, of the isblank function (to which [:blank:] is related:

The isblank function tests for any character that is a standard blank character or is one of a locale-specific set of characters for which isspace is true and that is used to separate words within a line of text. The standard blank characters are the following: space (’ ’), and horizontal tab (’\t’). In the "C" locale, isblank returns true only for the standard blank characters.

[:blank:] is only the same thing as [\t ] (tab space) if you run your scripts and Awk and everything in the "C" locale.

link
nerdponx 217 days ago
Interesting, the GNU Grep manual describes both character classes as behaving as if you are in the C locale. I shouldn't have assumed it was the same as in the C standard!
link
dietrichepp 217 days ago
> Why are you using the locale-specific [:space:] on source code?

Because it’s the one I remembered first, it worked, and I didn’t think that it needed any improvement. In fact, I still don’t think it needs any improvement.

link