[themafia]

The context is, pull requests of this magnitude were expected before the merge window, and this was sent after and made these modifications to generic header files used in other sub-trees. This has also happened previously.

So the commentary was on more than just the code it was on the entire situation. It was concluded by saying they could do this but not in generic headers and they could try the PR again early in the next release.

That language was not meant to be inflammatory but stern and the door was left wide open for future submissions.

Would I mind this in my workplace? Probably not. Particularly if my boss was a well known programmer with decades of experience and inside knowledge to share with me.

[chris_wot]

The thing is, if he got this patch at the right time, what’s the bet he would have said this is bad code, gave the same feedback but toned it down?

I get the sense that he’s more upset by the timing, and whilst unimpressed with the code, he’s reacting because of the timing. Hard to tell though because of the way that email is written.