| You know, you can actually express your feedback without derogatory remarks. You don't need to sugarcoat it. Let's try that message from Torvalds again, without the diatribe and invective: > No. The quality of this code is dreadful and it came in too late. I asked for early pull requests because I'm traveling, and if you can't follow that rule, at least make the pull requests good. Slight tweak. > This adds various poor quality code that isn't RISC-V specific to generic header files. garbage -> code > I am extremely upset that you have sent me such badly written code so late in a merge window. you know, he's not so upset with the code, but he's upset with the timing. What's the bet he might have been a bit nicer if it had been sent in well before the merge window. > Take for instance this make_u32_from_two_u16() helper function. This function makes code incomprehensible, and actively WORSE than not using it in the first place. "That thing makes the world actively a worse place to live." but does it? Lots of things make the world a worse place to live in. Disease, crime, DOGE... but does a
helper function actively degrade the ability to live in the world? > If you write the code out as "(a << 16) + b", you know what it does and which is the high word. Maybe you need to add a cast to make sure that 'b' doesn't have high bits that pollutes the end result, so maybe it's not going to be exactly _pretty_, but it's not going to be wrong and incomprehensible either. See, was that hard? I didn't change any of this. > In contrast, if you write make_u32_from_two_u16(a,b) you don't know what the word order is. IOW, you just made things WORSE, and you added that helper function to a generic non-RISC-V file. If others people use this, then it will make other code worse too. I hardly changed this, but I didn't sugar coat it. > So no. Please don't include these sort of functions in the code. It does not go into generic header files, and it damn well does not happen late in the merge window. Note I kept in the "damn well". > You're on notice: no more late pull requests, and no more unrelated code outside the RISC-V tree. This is fine. Torvalds is upset, for good reason. > Now, I would hope there's no similar code inside the RISC-V parts, but that's your choice. But things in generic headers do not get polluted by this sort of stuff. And sending a big pull request the day before the merge window closes in the hope that I'm too busy to care is not a winning strategy. Smallest tweak. > So you get to try again in 6.18. EARLY in the that merge window. And without the garbage. No change, even got a chance to use the word "garbage". Perhaps I should put this in a way that you might enjoy though: Torvalds is a dick in his communication and a stunted human being. His inability to communicate to others makes them feel bad despite the fact they evidently put in a lot of time and effort to make things better and when they make him angry he can be a petty little shithead who has no control over his emotions. |
See, you're talking about the person, whereas Linus was talking about the code and the behavior of submitting such code late. Linus' thing is much nicer