[tlonny]

The rank disrespect of somebody asking you to review something they haven't even looked at is eye watering.

I feel like AI-induced brain-rot of engineers is inevitable. Unless we see AI leapfrog into something close to AGI in the future (certainly not ruling this out), I think there will be very lucrative careers available to engineers who can maintain a balanced relationship with AI.

[roarcher]

I'm glad I'm not the only one who gets viscerally irritated when I'm asked to review a PR that was obviously generated. You didn't take the time to write this code, but you expect me to take the time make sure it's correct, which will take far longer than a regular PR because there's no reason to assume an LLM even understood the task. Next time just be honest and ask me to do your work for you.

[Ntrails]

> You didn't take the time to write this code, but you expect me to take the time make sure it's correct

So, I guess there are a couple parts here right? I might not take the time to write the code, but surely I am on the hook to demonstrate that I've tested the code or have very good reason to believe it's correct?

If people are pushing PRs [of any meaningful complexity] without knowing whether they work in the general case that sounds like a failure of process and/or training. For me PRs are about catching edges?

[roarcher]

I'll quote from my parent comment:

> somebody asking you to review something they haven't even looked at

The situation you're talking about is not the one we're talking about, so I'm not sure what you're taking issue with.

[virtue3]

My boss decided to start putting out a ton of PRs from Devin at one point. I told him I'm spending more time reviewing his PRs than he was saving.

[kardianos]

I just felt this recently. I was sent some code for me to put into prod, a long running service. And in one func, which returned an error (Go) but still called "os.Exit" in each error handler rather then returning.

Fixing the issue was a small matter. But the amount of disrespect I felt, that I looked at it closer then anyone else apparently (which wasn't really all that close at all), when they were ostensibly building this code, that disrespect was just immense.

[qmr]

Stop saying engineer when you mean programmer.

It’s an insult to real engineers.

[zarzavat]

People making siege engines?

[realisticfoo]

Well no one actually asked you for a review, it's just a stupid checkbox item some boomer added to the list of other useless checkbox items - like group calls where everyone is just reading list of closed tickets we can all read ourselves in jira. This self righteous bullshit makes the whole ordeal even more insufferable.

[gherkinnn]

Code reviews are one of the few ordeals worth doing. They catch problems and transfer knowledge. In a reasonably well run org (it doesn't take much) code reviews are easily a huge net benefit.

As for "reading closed tickets", you are right. It is silly. Alas, in apathetic orgs it is a reliable way to get some people know what is going on some of the time. And that particular ordeal keeps the tickets somewhat in sync with reality.

[roarcher]

Consider that your experience may not be universal. Just because your reviews are useless rubber stamps to satisfy "some boomer" does not mean that other shops also have no standards. I get explicitly asked for reviews at work all the time, and I'm expected to actually understand the code and provide useful feedback.

By the way, you don't have to give useless reviews even if your coworkers do. It sounds like your workplace is infected with complacency, but there's no law that says you can't do better.

[craftkiller]

If you saw the nonsense some of my teammates try to commit, you would have a completely different view on code review. Just off the top of my head in the past 3 months, they have:

  - Written a 1-line function that returns a literal, but they pointlessly made the function async and added a @cache decorator.
  - Used try/catch to catch ALL exceptions, and then just ignored the exception causing code elsewhere to explode.
  - Used try/catch to catch ALL exceptions, and then log that an authentication error happened. Did the request time out? Well the logs now lie to you and say it was an authentication error.
  - Replace a log statement for a very serious error with a logging.warning() because that makes the error no longer show up on our reports.

If code reviews are that useless to you, that must mean either your team is completely homogeneous in terms of skill level and knowledge, or no one is taking the code reviews seriously.