[krig]

Sorry to hear that! I haven’t had any such experience, quite the opposite.

But I’m also an old. If someone tells me my code is shit, 1) they are probably right, and 2) I don’t really care. I can probably look at their code and find flaws in it.

In the end, Odin is Bills project and he decides what goes into it, I’m fine with that.

[johnisgood]

From what I remember, it was supposed to land in vendor/ which is not the core standard library though. Additionally, it is one thing to say the code is shit, and another to say "too many things wrong, fuck off", all while the code did work properly! From what I recall the person said he will continue working on it anyway in his own git repository. I think he could have given pointers of these major flaws (I checked the code and I could not find anything either[1]), which could have not been too major if the code worked properly (there were test cases, it did actually work and there were no memory leaks either, FWIW).

> In the end, Odin is Bills project and he decides what goes into it, I’m fine with that.

Me too. I am just not going to contribute. No big deal.

> I haven’t had any such experience, quite the opposite.

Just to add some positive, too: I have had positive experiences with other contributors.

In any case, I follow the programming language's developers before I contribute, as you may have noticed.

[1] But then again, I do not know the language too well either. Those pointers would have helped me and many others.

[krig]

> Me too. I am just not going to contribute. No big deal.

Makes sense! Plenty of other languages and projects out there.

[johnisgood]

My question to you, however, is this: what would have you done if he were to tell you that he can write your code way better (without any pointers) and that concludes the conversation? Would you not have expected at least SOMETHING as to what is wrong with it? Of course ultimately what he says and does is his own business, but I am asking you.

> Plenty of other languages and projects out there.

You are right. I do like Odin though, as a language, so it is a pity.

[krig]

I don’t think he works for me. I am not paying him. To the contrary, if anything _I_ am in debt since I am using all this code that he put out there for free.

I guess there are a few things I could do in that situation. Move on to something else, try to figure out why he didn’t like it on my own, fork the language if it’s big enough and important enough to me.

But yeah, maybe he is busy? Maybe he thinks you are capable of working it out yourself?

Not to be too harsh about it, but yeah, that’s just the way it is sometimes. Maybe he was having a bad day, that happens to people.

[jodrellblank]

> "what would have you done if he were to tell you that he can write your code way better (without any pointers) and that concludes the conversation?"

Depends on my mood; maybe go to the Odin Reddit, Discord or CodeReview StackExchange and say "GingerBill has rejected my PR for 'many problems' can I get some hints what, so I can make a better PR?" and then take my better PR back and update the original making it as clear as I can that I have made a good faith effort to improve it.

Or wait a couple of days (weeks?) and review my code with fresh eyes (and wait for the reviewer's mood to change).

Or reply "I'd be happy for you to rewrite it better, I just want the feature it doesn't have to be my code"

Or ask "Many problems, but how many of them are dealbreakers? Is there a route to a minimally viable commit which settles on a good enough interface, and the rest of the implementation can be improved later?"

Or ask "I'd hope you can write it better, you've been Odinning a lot longer than I have, can you point out some of the problems so I can learn more?"

Or if I was giving up on getting it committed, "You say you can write it better, so are you going to?"

> "Would you not have expected at least SOMETHING as to what is wrong with it?"

I have been on the internet long enough to be on both sides of "it's nice to be nice" and "where to start it's not even wrong" and to expect busy, capable, computer people to be time crunched and terse/blunt. There's a difference between "many problems" and "many problems, Get The Fuck Out". A difference between what Linus Torvalds and Erik Naggum used to do and a 3 second glance "too many problems to commit, rejected". Have you seen the accusations of what goes on behind closed doors in the C++ standards committee? Or Scheme world?[1] Does that put you off the languages or is that fine because it only happens to other people?

Progressive disclosure could say that if you cared and wanted to fix up the PR you would have engaged and asked, and if you didn't ask that suggests you weren't interested and that saved Bill's time writing a longer comment. I guess I expect that the Thing_I_Want is not something others care about and if I want to 'change the world' I will have to push some boulders up hill to get there, or push some people to drag their attention to my thing instead of whatever they are doing, and Thing_I_Want generally is not world changing enough to warrant that.

[1] I could go and find them and link them here, but I'm not going to because you might a) know, b) not care, and if I do then I'll get dragged into HN arguments about those accusations which isn't really relevant, but your grudge would be stronger if you had many documented examples showing a pattern of rude, cruel, damaging behaviour, rather than one example which you remember as being unfairly rude but can't find.

[johnisgood]

It is not my code, but since I want to know what is wrong with it, might as well ask around.

> it only happens to other people?

What I am talking about did happen to someone else, not me.

In any case, I will take your advice and ask around despite it not being my code, but I genuinely want to know what is wrong with it because I took a look at the code and I could not spot any issues with it, and I tested it, it works, so I wonder what really is wrong with the code despite its test cases passing, and the code seemingly being organized and seems to be Odin-style. He mentioned something about the person not knowing what "distinct" is, but he also said "many things are wrong, so many that he would rather just rewrite it himself" (which I doubt he has any intentions of doing). These issues surely cannot be such deal-breakers considering the code does run (without any memory leaks). I will ask around when I can be bothered.

[jodrellblank]

> I genuinely want to know what is wrong with it ... when I can be bothered.

https://odin-lang.org/community/ - here's the forum, the IRC channel, the Discord invite, the subReddit link, or you could have commented in GitHub in the PR while you were looking at it.

All of these would be less effort than the comments you've made here in this thread, instead you've taken a second hand grudge and used it to give a small project a good kicking based on an exchange you haven't linked here for any reader here to form a judgement about, for reasons you don't understand and can't be bothered to find out, and then accused people of being bots and astroturfing. [I have followed two of Karl Zylinski's videos in Odin last winter; I have not used Odin in months. I have no stake in Odin].

How is that reasonable behaviour, a useful HN comment for HN readers, fair to GingerBill / Odin, or a step towards getting you the information you "genuinely want to know"?

[uncircle]

> But I’m also an old.

That explains why the C code is so neat. You don't see young'uns write such compact C code any more. Well done.

After years using higher-level languages, my C code has become verbose and clunky, when it doesn't necessarily have to be (and memory safety is no concern)

[krig]

That's the nice thing about a little side project, I can just have fun and noodle away at it without worrying about safety or comments ;)