[sytse]

Thank you for the heads up. I must say I've seen worse projects but I won't argue with the points you raised.

In general I think that compared to the alternatives Gitlab is the least complex to understand and install. Of course that doesn't mean it is perfect or easy. These two lines took us a few hours: https://github.com/gitlabhq/gitlabhq/pull/1263

I think the Gitlab author already did an awesome job and luckily there are many people sending in pull request, already more than 1200!

We try contribute our part. With the growth of Gitlab.io our contributions should grow as well.

[arthurschreiber]

Hah! Your pull request actually introduces subtle bugs into the diff view. I had already submitted _exactly_ the same change some months ago, and after having it enabled for some time in our gitlab installation at work, I ran into some issues.

I can't remember the exact preconditions, but there were cases where this change would start showing changes that were not even part of the merge request at all, which was extremely confusing.

In the end, I went ahead and did some more low-level changes to gitlab, so it would not only save the branch for a merge request, but it would save the actual commit shas of the source revision. That was much more accurate and reflects the way pull requests work on Github.

[sytse]

Thank you for the warning. Do you have a test case that reproduces the problem that you can share?