Hacker News new | ask | show | jobs
by prophesi 384 days ago
There are two binaries commited to the repo (cap_wasm_bg.wasm) but from what I can tell, it doesn't seem to be making any network calls or what have you. They still should get rid of them and add a Rust build step for their browser/node packages.
2 comments
HumanOstrich 383 days ago
Can you elaborate on why you would want this? You can run their build script[1] if you're trying to compare outputs and behavior.

[1]: https://github.com/tiagorangel1/cap/blob/main/wasm/build.js

link
tiagozip 383 days ago
you can compare the hashes of the wasm lmao the build script is very much public
link
prophesi 383 days ago
It's not a good practice to commit binary blobs in a repository. And I don't think it would be difficult to add a prepublish step to your npm packages so that you can remove them. The end user shouldn't need to run the build script and compare hashes whenever the source code changes.

Very surprised to get pushback on what I thought was an industry standard lmao

link
tiagozip 380 days ago
feel free to make a pr to add a worker, currently not my first priority tho
link