|
|
|
|
|
by bboreham
394 days ago
|
|
I took a look at the code, to see how I would react as a reviewer. In the first file I opened, I got as far as here: https://github.com/Sleepful/mymail/blob/main/app/router/page... // Create a context variable that inherits from a parent, and sets the value "test".
// Create a context key for the theme.
ctx, err := getEmails(pb, e)
First line is very weird, unrelated to the task. Maybe copy-paste from a sample in a blog post? Anyway not paying attention to leave it in.Wording in the second line is not consistent with third. I’d stop my review there. Lack of attention to detail. Author does not demonstrate an ability to think clearly. |
|