Hacker News new | ask | show | jobs
by EnPissant 419 days ago
What's the difference between this and squash merging PRs? A commit or a PR can be large. I don't see the difference.
2 comments

> A commit or a PR can be large. I don't see the difference.

They made it pretty clear they're talking about not-large commits. And they're contrasting that with any-size PRs.

That's a false dichotomy, lurker. A PR or a commit can be large or small.
It's not a false dichotomy. They're just using different terms than you would, based on their experience with how the people around them use those systems.
It's comparing carefully manicured git history hacking to unregulated PRs. It's pure dogma.
You agree that they are making a real comparison between two different things.

But you also say it's pure dogma?

I'm confused.

>I loathe GitHub PRs because of this. Working at $dayjob the unit of change is the commit, and every commit is reviewed and signed off by at least 1 peer.

Because this is exactly what a squash merged PR is. There is no meaningful difference unless you say "but commits are done by good people and PRs are done by bad people".

I think it's the review process. Do you review 1 commit or multiple?